[Frontend] Fix Flaky MCP Streaming Test#32153
Merged
DarkLight1337 merged 1 commit intovllm-project:mainfrom Jan 12, 2026
Merged
[Frontend] Fix Flaky MCP Streaming Test#32153DarkLight1337 merged 1 commit intovllm-project:mainfrom
DarkLight1337 merged 1 commit intovllm-project:mainfrom
Conversation
Signed-off-by: Daniel Salib <danielsalib@meta.com>
daniel-salib
requested review from
DarkLight1337,
NickLucche,
aarnphm and
robertgshaw2-redhat
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request addresses a flaky test, test_mcp_code_interpreter_streaming, by replacing a simple math problem with a more complex one to ensure the MCP tool call is consistently triggered. The change is straightforward, well-explained, and appears to be an effective fix for the test's flakiness. I find no issues with this modification.
chaunceyjiang
added
the
ready
DarkLight1337
approved these changes
Jan 12, 2026
TomerBN-Nvidia
pushed a commit
to TomerBN-Nvidia/vllm
that referenced
this pull request
Jan 13, 2026
Signed-off-by: Daniel Salib <danielsalib@meta.com> Signed-off-by: Tomer Natan <tbarnatan@computelab-frontend-8.nvidia.com>
sammysun0711
pushed a commit
to sammysun0711/vllm
that referenced
this pull request
Jan 16, 2026
Signed-off-by: Daniel Salib <danielsalib@meta.com>
akh64bit
pushed a commit
to akh64bit/vllm
that referenced
this pull request
Jan 16, 2026
Signed-off-by: Daniel Salib <danielsalib@meta.com>
dsuhinin
pushed a commit
to dsuhinin/vllm
that referenced
this pull request
Jan 21, 2026
Signed-off-by: Daniel Salib <danielsalib@meta.com> Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com>
ItzDEXX
pushed a commit
to ItzDEXX/vllm
that referenced
this pull request
Feb 19, 2026
Signed-off-by: Daniel Salib <danielsalib@meta.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
test_mcp_code_interpreter_streaming is occasionally failing due to inconsistent behavior of whether it decides to trigger a tool call. Since the math question is too simple, a tool call isn't always triggered. A more complicated math problem like "123 * 456" consistently triggers the MCP tool call
Test Plan
pytest entrypoints/openai/responses/test_harmony.py::test_mcp_code_interpreter_streaming
Test Result
Consistently passes unit test
Note
Cursor Bugbot is generating a summary for commit 3d2756b. Configure here.